Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-phrase with space not working properly #38

Closed
gaoxiangluke opened this issue Jul 14, 2022 · 1 comment
Closed

multi-phrase with space not working properly #38

gaoxiangluke opened this issue Jul 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@gaoxiangluke
Copy link

Describe the bug
The new update work great for Japanese, when there is no space between phrase. But when I try to use it for English, the new phrase does not show up in different colors. I suspect this is because the English multiphase has space in between, while the Japanese one doesn't.

To Reproduce

  1. add the English language with the default setting
  2. add English text
  3. select multiple words and add a phrase
  4. color does not show up
    Expected behavior
    color should show up for the multi-word phrase.

Desktop (please complete the following information):

  • OS: Linux arm
  • Browser edge
@gaoxiangluke gaoxiangluke changed the title multi-phrase with space does not work multi-phrase with space not working properly Jul 14, 2022
@HugoFara HugoFara added the bug Something isn't working label Aug 11, 2022
@HugoFara
Copy link
Owner

Hello,

Thanks for signaling this issue, I was unable to tackle it since I was far from LWT this last month. In my last commit, I could solve much of the problem, here are the changes:

  • There was a confusion between the attributes names of Term in edit_mword.php. "wordcount" was wrongly refereed as "word_count" at some points.
  • "insert_standard_expression" is a new function introduced in 2.5.0-fork, as I had to break the structure of "insertExpressions" (inc/session_utility.php), because it was too complex. By doing so, I rewrote part of the code which resulted in bad behavior for texts using spaces.

Finally, after a good day of battle with the code, I could solve those issues. I still have to makes some checks before the final release (newt week?), but the work is more or less done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants