Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Added .gitattributes with force unix newline conversion for *.md files #132

Merged
merged 2 commits into from Feb 10, 2016
Merged

[RFR] Added .gitattributes with force unix newline conversion for *.md files #132

merged 2 commits into from Feb 10, 2016

Conversation

w0robey
Copy link
Contributor

@w0robey w0robey commented Feb 10, 2016

Added force newline conversion *.md files for correct work export-script on Windows system.

Specifically, for this part:

// bin/export   line:14

    // Not worked with Windows line endings
    // In example, '#TITLE\r\n\r\nDESCRIPTION'.match(/^.*\n+([\s\S]+)|^/)[1] is '\r', not 'DESCRIPTION'
    markdown: content.match(/^.*\n+([\s\S]+)|^/)[1]

@KittyGiraudel
Copy link
Owner

That is a good idea. :)

KittyGiraudel
KittyGiraudel reviewed Feb 10, 2016
View reviewed changes
.gitattributes
@@ -0,0 +1 @@
*.md text eol=lf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t it ironic how this file is missing EOF? :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, suprise from online editor :)

KittyGiraudel added a commit that referenced this pull request Feb 10, 2016
@KittyGiraudel
Merge pull request #132 from w0robey/line-ending-fix
3a52cb2 
Add .gitattributes with force unix newline conversion for *.md files
@KittyGiraudel KittyGiraudel merged commit 3a52cb2 into KittyGiraudel:master Feb 10, 2016
@KittyGiraudel
Copy link
Owner

Thank you! :)

@w0robey w0robey deleted the line-ending-fix branch February 10, 2016 16:50
@w0robey
Copy link
Contributor Author

w0robey commented Feb 10, 2016

👍

@KittyGiraudel KittyGiraudel changed the title Add .gitattributes with force unix newline conversion for *.md files [RFR] Added .gitattributes with force unix newline conversion for *.md files Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w0robey @KittyGiraudel