Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx external link issue #15

Closed
HuidaeCho opened this issue Jun 16, 2021 · 5 comments
Closed

Sphinx external link issue #15

HuidaeCho opened this issue Jun 16, 2021 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@HuidaeCho
Copy link
Owner

@ocsmit Please look into this issue sphinx-doc/sphinx#9351. The link to GRASS GIS module in the sidebar doesn't work. Maybe, we should leave it like that for a while so the sphinx devs can check it? Anyway, we need to either fix this issue or just create an almost-empty page that simply forwards to the external link, which I don't prefer personally. I guess, it could be a theme issue?

@HuidaeCho HuidaeCho added the documentation Improvements or additions to documentation label Jun 16, 2021
@HuidaeCho
Copy link
Owner Author

No matter what, we should fix it ourselves cleanly and create a PR for Sphinx, ideally.

@ocsmit
Copy link
Collaborator

ocsmit commented Jun 16, 2021

I agree. Will look into it. Would love for us to be able to fix it and contribute directly.

@ocsmit
Copy link
Collaborator

ocsmit commented Jun 16, 2021

Appears to be a theme issue. Tested with default theme and it links to no problem.

@ocsmit
Copy link
Collaborator

ocsmit commented Jun 16, 2021

Check new docs. Should work.

@HuidaeCho
Copy link
Owner Author

Great! Looks great and more familiar. You also fixed the sentence case! Did you have to fork the Sphinx and make any changes? No support for sentence case from the upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants