[RELEASE] 1.6.0 #276
[RELEASE] 1.6.0 #276
Conversation
Add a new Decorator (will need to be added to any DB command!) and break EVERYTHING.
[Halpy-142] Remove Old DB Command Logic See merge request hull-seals/code/irc/halpybot!144
[Halpy-140] Refactor duplicated fact code See merge request hull-seals/code/irc/halpybot!145
Also updates the version string, as we are working on 2.x Alpha
This code isn't actually used or called anywhere, and so should be removed.
Adds a Timed Task decorator that can be applied to create functions that run, non-blocking, in the background. If you want these tasks to loop, the function called with the decorator can establish their own loop. This is useful for future content.
[Fix] Remove Old Code & Implement Timed Tasks See merge request hull-seals/code/irc/halpybot!146
HBOT currently (if connecting directly) spits out the Python version and AIOHTTP version we are using in the server response. While we can't remove the SERVER response header, we can add our own custom useragent to preempt the one that leaks data. Fully detailed server headers is bad security practice.
Adds a five-minute timed Offline Mode Check to validate that OFFLINE MODE is not set. If it is set, warns Oper and the system monitoring channel set in config. Also adds a scheduled, automatic syncing of the Fact database with HalpyBOT on a weeklybasis. Also removes two unused configuration flags that are left over from cut content.
Is this proper? Probably not. But it works. I think. I'll review this again later.
I'm an idiot. No further questions.
Runs Hourly
The args have to be in list format because of how this system works we're hijacking. So now it is.
We should have done this from the get-go but we didn't know better
[Halpy-143] Apply Timed Tasks & Minor Updates See merge request hull-seals/code/irc/halpybot!147
Removes the delayed system and associated content in prep for 2.0, updated dependencies, fixed a few type issues, and minor general cleanup for 2.0.
|
In GitLab by @rik079 on Jul 7, 2022, 12:43 Commented on halpybot/commands/notify.py line 241 It certainly does work, at least under normal circumstances. Your point is valid regardless, closing this one as it's sufficiently covered in other comments. |
|
In GitLab by @rik079 on Jul 7, 2022, 12:44 Commented on halpybot/commands/ping.py line 98 Will approve once Gitlab allows me to |
|
In GitLab by @rik079 on Jul 7, 2022, 12:56 Commented on halpybot/commands/time.py line 34 from timeit import timeit
print(timeit("'It is currently ' + current_utc + ' UTC on ' + current_monthday + ', ' + year",
setup="current_utc, current_monthday, year = '12:34', 'July 7', '2022'"))
> 0.167991
print(timeit("f'It is currently {current_utc} UTC on {current_monthday}, year {year}'",
setup="current_utc, current_monthday, year = '12:34', 'July 7', '2022'"))
> 0.09389919999999996That doesn't need any commentary I suppose 😄 |
|
In GitLab by @Rixxan on Jul 7, 2022, 13:00 Commented on halpybot/commands/forcejoin.py line 46 changed this line in version 10 of the diff |
|
In GitLab by @Rixxan on Jul 7, 2022, 13:00 Commented on halpybot/commands/ping.py line 98 changed this line in version 10 of the diff |
|
In GitLab by @Rixxan on Jul 7, 2022, 22:50 Commented on halpybot/commands/edsm.py line 178 changed this line in version 11 of the diff |
|
In GitLab by @Rixxan on Jul 7, 2022, 22:50 Commented on halpybot/commands/drill.py line 159 This diff is out of date. That issue was indeed fixed with 4a1671a. |
|
In GitLab by @Rixxan on Jul 7, 2022, 22:50 Commented on halpybot/commands/edsm.py line 175 Unsure what is being killed with fire - didn't we remove the offending str(er) here? |
|
In GitLab by @Rixxan on Jul 7, 2022, 22:50 Commented on halpybot/commands/edsm.py line 178 Consider it killed. |
|
In GitLab by @Rixxan on Jul 7, 2022, 22:50 Commented on halpybot/commands/time.py line 34 String concat effectively banished o7 |
|
In GitLab by @Rixxan on Jul 7, 2022, 22:50 Commented on halpybot/commands/time.py line 34 changed this line in version 11 of the diff |
|
In GitLab by @theunkn0wn1 on Jul 8, 2022, 24:35 Commented on halpybot/commands/edsm.py line 175 looks like an outdated delta strikes again |
|
In GitLab by @theunkn0wn1 on Jul 8, 2022, 24:38 Commented on halpybot/commands/notify.py line 145 there are two things that need to be done here:
|
|
In GitLab by @theunkn0wn1 on Jul 8, 2022, 24:38 Commented on halpybot/commands/notify.py line 241 deleting in other words, |
|
In GitLab by @Rixxan on Jul 9, 2022, 17:37 Commented on halpybot/commands/notify.py line 237 changed this line in version 13 of the diff |
|
In GitLab by @Rixxan on Jul 9, 2022, 17:37 Commented on halpybot/commands/notify.py line 241 changed this line in version 13 of the diff |
|
In GitLab by @Rixxan on Jul 9, 2022, 17:44 resolved all threads |
|
In GitLab by @stuntphish on Jul 14, 2022, 14:14 Commented on CLI/DSSAUpdater/src/carrier.py line 56 There any need for these to be public rather than protected or private? Keeping everything encapsulated is something I've always been taught to do so this makes me nervous |
|
In GitLab by @stuntphish on Jul 16, 2022, 16:23 Commented on halpybot/commands/edsm.py line 289
|
|
In GitLab by @Rixxan on Jul 17, 2022, 14:39 Commented on CLI/DSSAUpdater/src/carrier.py line 56 If we don't ever call them public, I'd say go ahead and update them to private. |
|
In GitLab by @Rixxan on Jul 17, 2022, 14:50 Commented on halpybot/commands/edsm.py line 289 Resolved by aff2a7f |
|
In GitLab by @Rixxan on Jul 17, 2022, 14:50 resolved all threads |
|
In GitLab by @stuntphish on Jul 17, 2022, 14:56 approved this merge request |
|
In GitLab by @rik079 on Jul 17, 2022, 14:57 approved this merge request |
In GitLab by @Rixxan on Jun 13, 2022, 20:38
Added:
awaitstatements. (@Rixxan)Changed:
Removed: