feat: encodding region selected as b64, greatly reduce url lengtth #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comparison allen v3, ~580 regions selected: - pre 2019 May release: 2854 char - post 2019 May release: 7390 char - this patch: 1997 char maintaining backwards compat
|
pre 2019 may release | post 2019 may release | this patch see above for comparison |
feat: implemented tests for encoding/decoding
|
new commits allow navigation position to be ciphered, shortening other parts of url. While this does make the url less readable, the shortening of URL should make it worthwhile before: 140 char | after 74 char
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparison allen v3, ~580 regions selected:
maintaining backwards compat