Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non portable project #308

Closed
PhyxionNL opened this issue Jun 30, 2014 · 10 comments
Closed

Non portable project #308

PhyxionNL opened this issue Jun 30, 2014 · 10 comments

Comments

@PhyxionNL
Copy link
Contributor

Can we also get a non portable project? The current portable project doesn't work on Windows XP (and Vista and 7) unless you install the KB2468871 update.

@hazzik
Copy link
Member

hazzik commented Jun 30, 2014

Windows XP?

@hazzik
Copy link
Member

hazzik commented Jun 30, 2014

Actually 👍

@PhyxionNL
Copy link
Contributor Author

We still have a large enough user base (15-20%) on Windows XP to justify it. Plus, it's also Vista and 7 if they don't have the KB2468871 update. I dislike the ability to force people to install an update in order to get it working.

@MehdiK
Copy link
Member

MehdiK commented Jul 2, 2014

So I don't think you want a non-portable project. You need a non portable build and nuget package, right?

@PhyxionNL
Copy link
Contributor Author

Yes, that is indeed correct MehdiK 👍

@MehdiK
Copy link
Member

MehdiK commented Jul 3, 2014

Ok. Makes sense. Don't promise to do this anytime soon though as it's a relatively significant effort to set up. In the mean time, you might want to script it up and host the non-PCL nuget locally.

@PhyxionNL
Copy link
Contributor Author

I currently check out git repo and link the files I need. Far from an ideal solution but it works in the mean time. Looking forward to a non portable build at least.

@PhyxionNL
Copy link
Contributor Author

Any progress on this? It isn't that much of an effort as all you have to do is copy the .csproj and link towards to the other files and change the target to .NET 4.0 Client Profile, such as this:
https://gist.github.com/Phyxion/ce0d5199ceaa03b07de0 (Create a HumanizerNET40 folder and add this file to it, then add the csproj to the solution and done). There are no folders in this project this way but it works just fine and is by far the easiest way to convert a project (basically replace Include=" with Include="..\Humanizer).

@MehdiK
Copy link
Member

MehdiK commented Nov 7, 2014

I don't like this approach as it would mean adding every new file or changes in the file structure to both projects which is a PITA. Consider what a change like #207 could mean for this solution? The problem you have is not with the way the solution is structured - it's the way it's complied plus the nuspec specs.

I think a better solution would be through MSBuild scripting to inject the target profile in the csproj and then have two separate nuspec files for two different nuget targets, and thus the slight complication.

@PhyxionNL
Copy link
Contributor Author

That sounds a better solution indeed. What I described above is not that much work though. Just fire up notepad and replace all. It only took me a few seconds to change the csproj file. It's far from ideal as its needs to be done manually. Too bad you cannot use the configuration manager in VS to add another target (at least not that I know of).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants