Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-badges #16

Closed
wants to merge 1 commit into from
Closed

fix-badges #16

wants to merge 1 commit into from

Conversation

kiwiroy
Copy link

@kiwiroy kiwiroy commented Apr 14, 2020

The badges aren't displaying due to whitespace. Also upgrade coveralls to svg.

no whitespace and svg > png
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.331% when pulling 260b786 on kiwiroy:patch-1 into 24422ba on Humanstate:master.

@leejo
Copy link
Collaborator

leejo commented Apr 15, 2020

Hi! Looks good, however I use the pod2markdown script to generate the README.md whenever I make changes in the POD so these changes will just be lost whenever I update that. I think the changes need to happen in the POD itself in lib/Business/GoCardless.pm then check that pod2markdown does the right thing - possibly there is a bug in that script/dist.

@kiwiroy
Copy link
Author

kiwiroy commented Apr 15, 2020

Sure thing, realised that was the case. I think the fix to the pod is to use =begin html =end html rather than =for html.

@leejo leejo closed this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants