Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iss#2 #3

Merged
merged 7 commits into from Apr 28, 2017
Merged

Fix iss#2 #3

merged 7 commits into from Apr 28, 2017

Conversation

whosgonna
Copy link

Fix for iss#2, Delivery Tag is not returned with basic_get.

Updated tests t/006_txn.t and t/007_get.t so the expected hashrefs have the delivery tag. Added test t/025_get_and_ack.t to disconnect with out ack, reconnect, and confirm that the message is requeued, then ack the message, and confirm that the message does not requeue after the ack.

per @leejo:
I would just make the first part of the change like so, however, to
prevent churn in the history:

return (
    content_header_frame => $headerframe,
    payload => $payload,
    ($args{delivery_tag} ? ( delivery_tag => $args{delivery_tag} ) : ())
);
delivery_tag is part of expected result in the 'commited payload' test
in t/006_txn.t
@whosgonna
Copy link
Author

When running prove tests t/020_bad_credentials.t and t/022_close.t fail on my system, but they fail out of Humanstate:master as well.

@leejo
Copy link

leejo commented Apr 28, 2017

Looks like it's failing against 5.24 on CI - I'll investigate this morning.

@leejo leejo merged commit a1034d7 into payprop:master Apr 28, 2017
@leejo
Copy link

leejo commented Apr 28, 2017

Note sure why this is failing in travis as it "works on my machine", which is 5.24 and against an actual test rabbitmq host:

givengain@givengaindev:/var/www/net-amqp-rabbitmq$ MQHOST=127.0.0.1 make test
Skip blib/lib/auto/share/dist/Net-AMQP-RabbitMQ-PP/amqp0-9-1.extended.xml (unchanged)
Skip blib/lib/Net/AMQP/RabbitMQ/PP.pm (unchanged)
PERL_DL_NONLAZY=1 "/var/www/tools/bin/perl5.24.0" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/*/*.t t/*/*/*.t
t/000_changes.t ..................... skipped: Test::CPAN::Changes required for this test
t/000_kwalitee.t .................... skipped: Test::Kwalitee required for this test
t/001_declare_exchange.t ............ ok
t/001_load.t ........................ ok
t/002_publish.t ..................... ok
t/003_consume.t ..................... ok
t/004_selfconsume.t ................. ok
t/005_noack.t ....................... ok
t/006_txn.t ......................... ok
t/007_get.t ......................... ok
t/008_queue_declare.t ............... ok
t/009_no_route.t .................... ok
t/010_qos.t ......................... ok
t/011_hearbeat.t .................... ok
t/012_timeout.t ..................... ok
t/013_headers.t ..................... ok
t/014_bind_with_headers.t ........... ok
t/015_declare_queue_with_headers.t .. ok
t/016_reject.t ...................... ok
t/017_queue_delete.t ................ ok
t/018_cancel.t ...................... ok
t/019_consumer_cancel.t ............. ok
t/020_bad_credentials.t ............. ok
t/021_read_timeout.t ................ ok
t/022_close.t ....................... ok
t/023_keepalive.t ................... ok
t/024_exclusive_consume.t ........... ok
t/025_get_and_ack.t ................. ok
All tests successful.
Files=28, Tests=247, 32 wallclock secs ( 0.08 usr  0.16 sys +  2.17 cusr 10.73 csys = 13.14 CPU)
Result: PASS
givengain@givengaindev:/var/www/net-amqp-rabbitmq$ /opt/tools/bin/perl -V | head
Summary of my perl5 (revision 5 version 24 subversion 0) configuration:

  Platform:
    osname=linux, osvers=3.13.0-91-generic, archname=x86_64-linux
    uname='linux vagrant-ubuntu-trusty-64 3.13.0-91-generic #138-ubuntu smp fri jun 24 17:00:34 utc 2016 x86_64 x86_64 x86_64 gnulinux '
    config_args='-Dprefix=/opt/tools -Dotherlibdirs=/opt/tools/testing/lib -d -A ccflags=-fPIC'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef

Anyway, I'm going to push this out to CPAN and raise an issue to look at later. Thanks for the contribution!

@leejo leejo mentioned this pull request Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants