New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iss#2 #3
Fix iss#2 #3
Conversation
per @leejo: I would just make the first part of the change like so, however, to prevent churn in the history: return ( content_header_frame => $headerframe, payload => $payload, ($args{delivery_tag} ? ( delivery_tag => $args{delivery_tag} ) : ()) );
delivery_tag is part of expected result in the 'commited payload' test in t/006_txn.t
When running prove tests t/020_bad_credentials.t and t/022_close.t fail on my system, but they fail out of Humanstate:master as well. |
Looks like it's failing against 5.24 on CI - I'll investigate this morning. |
Note sure why this is failing in travis as it "works on my machine", which is 5.24 and against an actual test rabbitmq host:
Anyway, I'm going to push this out to CPAN and raise an issue to look at later. Thanks for the contribution! |
Fix for iss#2, Delivery Tag is not returned with basic_get.
Updated tests t/006_txn.t and t/007_get.t so the expected hashrefs have the delivery tag. Added test t/025_get_and_ack.t to disconnect with out ack, reconnect, and confirm that the message is requeued, then ack the message, and confirm that the message does not requeue after the ack.