Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access_token_ttl to be passed as callback #29

Merged
merged 1 commit into from Jul 20, 2020

Conversation

vskrupskis
Copy link

In some scenarios we might have some specific business logic where TTL
depends on the client or other similar conditions.

To support client specific TTL allow access_token_ttl to be passed as
callback so that we can call our own conditions on what the lifespan of
the token should be.

@vskrupskis vskrupskis requested a review from leejo July 20, 2020 11:26
@coveralls
Copy link

coveralls commented Jul 20, 2020

Coverage Status

Coverage increased (+0.05%) to 97.237% when pulling 7024ff6 on valters/access_token_ttl_as_callback into f90a4cc on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 97.237% when pulling 60a74a1 on valters/access_token_ttl_as_callback into f90a4cc on master.

In some scenarios we might have some specific business logic where TTL
depends on the client or other similar conditions.

To support client specific TTL allow `access_token_ttl` to be passed as
callback so that we can call our own conditions on what the lifespan of
the token should be.
@vskrupskis vskrupskis force-pushed the valters/access_token_ttl_as_callback branch from 60a74a1 to 7024ff6 Compare July 20, 2020 11:38
@leejo
Copy link
Contributor

leejo commented Jul 20, 2020

Looks good! Merging, will be on the way to CPAN shortly.

@leejo leejo merged commit 3140c32 into master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants