Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire EventWindowScreenChange when screen parameters change #117

Open
tonsky opened this issue Aug 19, 2021 · 3 comments
Open

Fire EventWindowScreenChange when screen parameters change #117

tonsky opened this issue Aug 19, 2021 · 3 comments
Labels
Design API design is needed before implementation Not sure

Comments

@tonsky
Copy link
Collaborator

tonsky commented Aug 19, 2021

No description provided.

@tonsky tonsky added Design API design is needed before implementation Not sure labels Aug 29, 2021
@i10416
Copy link
Contributor

i10416 commented Feb 8, 2022

What kind of event will EventWindowScreenChange handle?

Is EventWindowScreenChange supposed to notify resolution change like ScaleFactorChanged in winit? https://github.com/rust-windowing/winit/blob/1b3b82a3c1369c5248a2e6a251230ba6c615e918/src/dpi.rs#L55

@tonsky
Copy link
Collaborator Author

tonsky commented Feb 8, 2022

Yes, scale, resolution, color space etc

@i10416
Copy link
Contributor

i10416 commented Feb 8, 2022

Thanks. EventWindowScreenChange seems to be something much general.

Can I ask why you prefer sending them at once as EventWindowScreenChange, rather than notifying these changes separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design API design is needed before implementation Not sure
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonsky @i10416