Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface::makeImageSnapshot crashes if _nMakeImageSnapshotR returns null #23

Closed
Sm0keySa1m0n opened this issue May 29, 2022 · 1 comment
Closed

Surface::makeImageSnapshot crashes if _nMakeImageSnapshotR returns null #23

Sm0keySa1m0n opened this issue May 29, 2022 · 1 comment

Comments

@Sm0keySa1m0n
Copy link

Surface::makeImageSnapshot is correctly marked as @Nullable because _nMakeImageSnapshotR can return a null pointer. However, it doesn't check whether _nMakeImageSnapshotR returns null and instead always calls the Image constructor which will crash if the pointer is null.
@tonsky tonsky closed this as completed in 771b708 May 30, 2022
@tonsky
Copy link
Contributor

tonsky commented May 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonsky @Sm0keySa1m0n