Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #HuolalaTech/page-spy-web
发现了好几个问题, 我一并修改了
问题一: 这里的拷贝和提示的文案, 不应该使用英文. 虽然copy这个单词很简单, 但是用户可能不认识, 沟通起来也麻烦, 作为用户端的文案, 还是中文比较好. 但是调试信息我没动, 因为这些是给开发看的, 保持现状就好.
解决方案: 这个直接改就行, 简单
问题二: 组件设计问题. 这个有点复杂, alert的动作目前是发生在content组件中的. alert是个业务行为, content看文件结构和命名, 像是个ui组件. 但是里面又处理了大量的业务, 比如拷贝业务. 举个例子, 按钮的点击动作, 写死为触发拷贝行为. 但并不是每次使用content都需要执行拷贝动作. 所以这里最大的问题其实是content的定位不清晰. 准确的说, 这里的content和modal应该是一个东西. 但实际上content是部分业务+部分modal的行为.
解决方案: 将content的行为精简化, 业务全部交由外部传递, 提高content的复用性.
问题三: alert的交互是无法避开的, 但是alert本身又会阻塞线程
解决方案: 我看了这个项目没有引入太多依赖, 连react都没有. 所以最适合的antd message组件都没法用. 我也理解作为sdk肯定是越小越好, 但是其他的交互体验都没有那么好, 尤其是在现有content的设计下, 并不好实现. 所以我建议引入一个纯js轻量的 toast 组件.