Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Purge Extension Element #30

Open
Hutchy68 opened this issue Dec 15, 2020 · 3 comments
Open

Rename Purge Extension Element #30

Hutchy68 opened this issue Dec 15, 2020 · 3 comments

Comments

@Hutchy68
Copy link
Owner

In the past week it was discovered that Semantic MediaWiki is stepping on the code of the Purge extension. Purge has been using the element #ca-purge with the word "Purge" in the link in page actions (edit, history, move, etc.) no matter what skin the user is using.

If SMW is installed and the Purge extension is installed, SMW has a page refresh function in the page actions. Unfortunately, SMW attaches itself to the same element #ca-purge and overwrites the word "Purge" with the word "Refresh" while dropping JS on top of Purge's JS. In other words, SMW completely disables the Purge extension from being used. I did look and at least SMW has a graceful backup to execute a no JS purge of the page cache with the action=purge link.

Proposing: Change element to #ca-purge-ext

Question: Should we change the text from "Purge" to "Page Cache Purge" or "Purge Cache" or something besides just "Purge"

@samwilson
Copy link
Contributor

Does it need to use an ID? Could it just be .ext-puge-link or something? If it's and ID then I agree it should contain ext-purge or similar.

As for the text, I've changed it on a few of my wikis to "Refresh" (shorter and users said it made more sense).

Also, there's a similar feature in Cargo, where it's called #ca-cargo-purge and "Purge cache".

@Hutchy68
Copy link
Owner Author

Well following output of all items in actions and menu etc should be an id. Wording can be thought about some more. Could even do something like “Latest version” or “Empty cache” or “Refresh page” or just leave it Purge.

@samwilson
Copy link
Contributor

Good point. In that case, #ca-purge-ext sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants