Revert my last pr #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuyHung1408
approved these changes
Apr 16, 2022
|
No problems! |
|
Btw, I recommend you to use the |
|
Thanks, will transfer to grid sometime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so, i investigated in this topic a little bit further (I think you say it like that) and found out, that the buttons actually dont change position when dark mode is enabled. The contrast between the border color of the white buttons and the white background is just so low, that they appear 1px smaller than they actually are, which is the reason that the dark buttons look like they are closer to each other. I will attach a video that shows this. Sorry for the inconvenience.
proof.mp4