Why reviewable.io for code reviews?

[asbjornu]

The comment by @elf-pavlik in #132 (comment), took me to the following statement by @lanthaler:

it's currently difficult to keep track what has been addressed and what hasn't

I realise I don't have much to say on this as I haven't phoned in on the Hydra conference calls, but I'm not sure I understand this argument.

There's quite extensive review support in GitHub and I haven't seen any of it put to use in this repository. What's missing on GitHub.com, specifically? Filtering based on review status is quite extensive, for instance:

It's also easy to ask for reviews, see who's reviewing a particular PR and their individual review status:

With the built-in review system, it's also possible to block merging before the review has been passed, for instance:

There are so many upsides to using the built-in code-review of GitHub that I don't quite understand the choice to use Reviewable. Can someone please explain them to me? 😃

[akuckartz]

👍

[lanthaler]

My main issue is that I don't see easily what has been changed between reviews and whether the comments have been addressed or not. In Reviewable it's pretty easy to follow along:

I can mark individual comments as blocking or resolved etc. and can also easily just look at files that have changed since I last reviewed a PR.

What's the concern regarding using Reviewable apart from "it's not GitHub"

[tpluscode]

I think I was undecided before, but indeed it's quite productive. Every time you visit you get to react to any new stuff and not waste time scrolling back and forth through tons of comments

[asbjornu]

Ok, I see. The functionality around individual comments is more limited on GitHub, I agree. But whenever a comment about the code is addressed by a new commit, GitHub will mark the comment "outdated" and collapse it. I find that functionality and a lot else to be better than Reviewable.

[lanthaler]

But whenever a comment about the code is addressed by a new commit, GitHub will mark the comment "outdated" and collapse it.

Yeah, but you can't track what happened with it. I kept scrolling back and forth and after I few rounds of reviews and comments by different people I usually completely lost track of where we stand.

I'd love if GitHub would integrate some of Reviewable's functionality (in a more performant, slightly less confusing manner). So far it's still missing some really important features which is why I strongly prefer Reviewable as it makes me much more efficient. Maybe give it a chance and try to weigh in on a few PRs over a few cycles. Perhaps you start to like it too :-)

[asbjornu]

Sure, I'll try it out. Thanks for the explanation!