Replace data structure of segment maps

[Hydrantz]

leds_screen/arduino/scoreboard.cpp

Lines 4 to 60 in 136535a

	byte seven_segment_map[10][8] = {
	{1,1,1,1,1,1,0,0},//0
	{0,1,1,0,0,0,0,0},//1
	{1,1,0,1,1,0,1,0},//2
	{1,1,1,1,0,0,1,0},//3
	{0,1,1,0,0,1,1,0},//4
	{1,0,1,1,0,1,1,0},//5
	{1,0,1,1,1,1,1,0},//6
	{1,1,1,0,0,0,0,0},//7
	{1,1,1,1,1,1,1,0},//8
	{1,1,1,1,0,1,1,0}, //9
	};
	byte sixteen_segment_map[42][16] = {
	{1,1,1,1,1,1,1,1,0,0,0,0,1,0,0,1},
	{0,0,1,1,0,0,0,0,0,0,0,0,1,0,0,0},
	{1,1,1,0,1,1,1,0,1,1,0,0,0,0,0,0},
	{1,1,1,1,1,1,0,0,1,1,0,0,0,0,0,0},
	{0,0,1,1,0,0,0,1,1,1,0,0,0,0,0,0},
	{1,1,0,1,1,1,0,1,1,1,0,0,0,0,0,0},
	{1,1,0,1,1,1,1,1,1,1,0,0,0,0,0,0},
	{1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0},
	{1,1,1,1,1,1,1,1,1,1,0,0,0,0,0,0},
	{1,1,1,1,1,1,0,1,1,1,0,0,0,0,0,0},
	{1,1,1,1,0,0,1,1,1,1,0,0,0,0,0,0},
	{1,1,1,1,1,1,0,0,0,1,0,1,0,0,1,0},
	{1,1,0,0,1,1,1,1,0,0,0,0,0,0,0,0},
	{1,1,1,1,1,1,0,0,0,0,0,1,0,0,1,0},
	{1,1,0,0,1,1,1,1,1,1,0,0,0,0,0,0},
	{1,1,0,0,0,0,1,1,1,0,0,0,0,0,0,0},
	{1,1,0,1,1,1,1,1,0,1,0,0,0,0,0,0},
	{0,0,1,1,0,0,1,1,1,1,0,0,0,0,0,0},
	{1,1,0,0,1,1,0,0,0,0,0,1,0,0,1,0},
	{0,0,1,1,1,1,1,0,0,0,0,0,0,0,0,0},
	{0,0,0,0,0,0,1,1,1,0,0,0,1,1,0,0},
	{0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0},
	{0,0,1,1,0,0,1,1,0,0,1,0,1,0,0,0},
	{0,0,1,1,0,0,1,1,0,0,1,0,0,1,0,0},
	{1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0},
	{1,1,1,0,0,0,1,1,1,1,0,0,0,0,0,0},
	{1,1,1,1,1,1,1,1,0,0,0,0,0,1,0,0},
	{1,1,1,0,0,0,1,1,1,1,0,0,0,1,0,0},
	{1,1,0,1,1,1,0,1,1,1,0,0,0,0,0,0},
	{1,1,0,0,0,0,0,0,0,0,0,1,0,0,1,0},
	{0,0,1,1,1,1,1,1,0,0,0,0,0,0,0,0},
	{0,0,0,0,0,0,1,1,0,0,0,0,1,0,0,1},
	{0,0,1,1,0,0,1,1,0,0,0,0,0,1,0,1},
	{0,0,0,0,0,0,0,0,0,0,1,0,1,1,0,1},
	{0,0,1,1,1,1,0,1,1,1,0,0,0,0,0,0},
	{1,1,0,0,1,1,0,0,0,0,0,0,1,0,0,1},
	{1,1,0,1,1,1,0,1,1,1,0,1,0,0,1,0},
	{1,0,0,1,0,1,0,1,1,1,0,1,1,0,1,1},
	{1,0,0,0,1,1,1,0,1,0,1,1,0,1,0,0},
	{0,0,0,0,0,0,0,0,1,1,1,1,1,1,1,1},
	{1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1},
	{0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0}
	};

Consider replacing data structures of seven_segment_map and sixteen_segment_map with more efficient options.

[idanai]

You can use binary literals and uint16_t: https://stackoverflow.com/questions/537303/binary-literals

Try something like this for storage:

uint8_t seven_segment_map[10] = {
	0b11111100,//0
	0b01100000,//1
	// etc...
};

uint16_t sixteen_segment_map[42] = {
	0b1111111100001001,
	0b0011000000001000,
	// etc...
};

Try something like this for access:

// mask: value with up to 32 bits. Types with less bits are complemented with 0s automatically when cast.
// bit_index: number of the bit [0..31]. 0 is LSB, 31 is MSB, greater will return 0.
bool read_mask_bit(uint32_t mask, uint8_t bit_index) {
	return (mask >> bit_index) & 1;
}

I also recommend making your arrays const or using constexpr to prevent accidental writes.