Tests for - fix the case of per-function custom Role #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/updateAliasStack.test.js
|
@HyperBrain I'm not sure about this fix, could you review? |
|
Relates to #88 as well BTW I use this fix in production, it works fine. |
|
@aleksdikanski could u review / approve? |
aleksdikanski
requested changes
May 10, 2019
lib/stackops/lambdaRole.js
Outdated
| }; | ||
| const dependencyIndex = _.indexOf(func.DependsOn, 'IamRoleLambdaExecution'); | ||
| func.DependsOn[dependencyIndex] = roleLogicalId; | ||
| if (_.isEqual(func.Properties.Role, { 'Fn::GetAtt': ['IamRoleLambdaExecution', 'Arn' ]})) { |
There was a problem hiding this comment.
I would suggest to not use if in this instance but use _.filter to select the right elements. This goes more with the functional approach, e.g.,:
_.forEach(_.filter(functions, func => _.isEqual(func.Properties.Role, { 'Fn::Gett': ... })), func => ...)
aleksdikanski
approved these changes
May 10, 2019
This was referenced May 10, 2019
Closed
defnotrobbie
pushed a commit
to 1stdibs/serverless-aws-alias
that referenced
this pull request
Nov 14, 2022
…role Tests for - fix the case of per-function custom Role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicate of #145 with tests written for case when function has custom role name.