Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few bugs and inconsistencies #15

Merged
merged 12 commits into from Feb 3, 2022
Merged

Fix a few bugs and inconsistencies #15

merged 12 commits into from Feb 3, 2022

Conversation

thesadru
Copy link
Contributor

@thesadru thesadru commented Feb 3, 2022 •
edited

See changelog.

  • no longer use explicit submodules unless they're exported
  • no longer use pass where it's not needed
  • ignore when 3rd party libraries are missing stubs
  • for the sake of user experience assume the class is initialized when annotating
  • make the colorama dependency optional (gawd the dependency management is funky)
  • allow for unloading miru and stopping all views

@thesadru
Fix a few bugs and inconsistencies
0c9c1d9 
no longer use explicit submodules unless they're exported
no longer use pass where not needed
ignore when 3rd party libraries are missing stubs
@thesadru
ssume class is initialized when annotating
4043b0f 
 for the sake of user experience
@thesadru
Install colorama only on win32 systems
5d77cc2
@thesadru thesadru marked this pull request as ready for review February 3, 2022 19:23
hypergonial
hypergonial previously approved these changes Feb 3, 2022
View reviewed changes
@hypergonial hypergonial added the enhancement New feature or request label Feb 3, 2022
@hypergonial hypergonial dismissed their stale review February 3, 2022 20:11

New commits pushed to branch.

@hypergonial hypergonial merged commit 64365b1 into hypergonial:main Feb 3, 2022
@thesadru thesadru deleted the fix/inconsistencies branch February 3, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypergonial hypergonial Awaiting requested review from hypergonial

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thesadru @hypergonial