Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing img instead of id #15

Closed
pniedzwiedzinski opened this issue Sep 15, 2019 · 2 comments
Closed

Passing img instead of id #15

pniedzwiedzinski opened this issue Sep 15, 2019 · 2 comments

Comments

@pniedzwiedzinski
Copy link

Function attack_success takes argument img which is an id of the image in the dataset. Wouldn't it be clearer if this variable is called img_id or something like this? Or we could pass the whole image from the dataset instead.

@Hyperparticle
Copy link
Owner

Yes, I agree this could be clearer if it was either called img_id or passed in the image itself. Looking back, I notice that the attack_success function in attack.py actually does pass in the image, so I think I can modify the Jupyter notebook to be the same.

@Hyperparticle
Copy link
Owner

I refactored the code, should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants