Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarter default value for the print_blob setting #2451

Closed
Zac-HD opened this issue May 28, 2020 · 0 comments · Fixed by #2512
Closed

Smarter default value for the print_blob setting #2451

Zac-HD opened this issue May 28, 2020 · 0 comments · Fixed by #2512
Labels
legibility make errors helpful and Hypothesis grokable opinions-sought tell us what you think about these ones!

Comments

@Zac-HD
Copy link
Member

Zac-HD commented May 28, 2020

The print_blob setting is currently a boolean, and defaults to False. This is sensible for local development, but ideally we'd like to enable it by default for remote CI runs.

hypothesis/hypothesis-python/src/hypothesis/_settings.py

Lines 610 to 612 in e0a74a0

settings._define_setting(
"print_blob",
default=False,

I think that passing default = bool(os.environ.get("CI")) would be sufficient. Thoughts?
@Zac-HD Zac-HD added opinions-sought tell us what you think about these ones! legibility make errors helpful and Hypothesis grokable labels May 28, 2020
@Zac-HD Zac-HD mentioned this issue Jul 25, 2020
Closed
@hugovk hugovk mentioned this issue Jul 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
legibility make errors helpful and Hypothesis grokable opinions-sought tell us what you think about these ones!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable print_blob for CIs, disable for local hugovk/hypothesis
1 participant
@Zac-HD