Faster strategy for arrays(..., unique=True)
#3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
faster-uniq-arrays
branch
4 times, most recently
from
aa565dc
to
f662686
Compare
Merged
rsokl
requested changes
Aug 30, 2021
Zac-HD
force-pushed
the
faster-uniq-arrays
branch
from
f662686
to
2aa87ee
Compare
Zac-HD
force-pushed
the
faster-uniq-arrays
branch
from
f51e947
to
cfb6b5e
Compare
rsokl
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3066.
Note that this doesn't change the behaviour for arrays which have a
fillstrategy; in those cases there's a tricky three-way tradeoff between speed, shrinking quality, and ability to assign elements to almost all indices (due to birthday paradox considerations). Since performance is a real concern for array strategies and we typically want to be sparse anyway, I've kept the existing behaviour for that branch.