Clean up extra.array_api.ArrayStrategy
#3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the clean-up part of #3105 as well as the relevant review commits. I included a test for 0d arrays (already passes).
I imagine we want to just not allow multi-dimensional array elements? If that's the case, I'll note writing checks that rely on Array API behaviour (i.e. not just
numpy.array_api) is pretty tricky (impossible?) to do efficiently... but relying on current behaviour leads to one or two obscure logical paths where we aren't raisingInvalidArgument. Basically, I will need to think about it more, and it's something tricky enough that I don't think will be appropriate for this PR.