Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing imports for hypothesis write numpy.save #3884

Closed
Zac-HD opened this issue Feb 14, 2024 · 0 comments · Fixed by #3886
Closed

Fix missing imports for hypothesis write numpy.save #3884

Zac-HD opened this issue Feb 14, 2024 · 0 comments · Fixed by #3886
Labels
enhancement it's not broken, but we want it to be better

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Feb 14, 2024

See https://zhd.dev/ghostwriter/?q=numpy.save

  • from pathlib import Path doesn't help when the repr is st.from_type(pathlib.Path)
  • doesn't import scalar_dtypes() or array_shapes(); try imports from our extras modules more generally

and after that we might want to manually test the ghostwriter on a variety of widely-used projects (e.g. PyPI most-downloaded, or NumFocus sponsored) to check for any other easy-to-fix issues.

@Zac-HD Zac-HD added the enhancement it's not broken, but we want it to be better label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant