feat(EU): New KIA models #480

Bubo08 · 2024-01-15T21:34:15Z

No description provided.

Bubo08 · 2024-01-15T21:37:57Z

Not everything is implemented, yet. Only the most important attributes from the vehicle status request are integrated. Therefore, at least some of the open issues could be closed.

fuatakgun

Looks good to me, please allow me a couple of days to test locally as an older car owner

fuatakgun · 2024-01-15T21:57:45Z

hyundai_kia_connect_api/Vehicle.py

@@ -74,6 +74,8 @@ class Vehicle:
    year: int = None
    VIN: str = None
    key: str = None
+    protocolType: int = None


Can you follow current naming convention?

Do you mean instead of Camel Case notation I should use underscore? Good point, I will fix it.

If protocol type isn't used in an if statement maybe we don't record it?

I fixed the naming and removed the attribute as proposed above. Additionaly, I continue with the mapping of the attributes.

cdnninja · 2024-01-17T17:05:22Z

I can't figure out how to post the review from mobile app.

Only thought is maybe renaming the ccs variable in vehicle to support multiple regions? I doubt other regions will call it that but still have versions. Thoughts on making it more universal?

Bubo08 · 2024-01-17T17:11:06Z

Only thought is maybe renaming the ccs variable in vehicle to support multiple regions? I doubt other regions will call it that but still have versions. Thoughts on making it more universal?

I think we can still refactor it, if it is the case. For me it looks a bit like a universal attribute but I might be wrong.

cdnninja · 2024-01-17T17:29:12Z

Each region is totally different. Ev9s haven't had issues so far for other regions as an example.

Bubo08 · 2024-01-17T18:22:16Z

I did see in older logs that the attribut Ccuccs2protocolsupport is set to 0 and in my sniffed code it is set to 1. So my interpretation was, that ccs2 was disabled in the past and now - in some newer cars - it is enabled.
Interestingly, this attribut is also used in the header of other type of calls (vehicles, register, ...).

But it is only an interpretation which might be completely wrong. The attribut could also mean Combined Charging System (CCS) but then why would it be included in all calls?

cdnninja · 2024-01-17T18:31:36Z

Interesting. So far I haven't seen this value in any other regions. I have seen a version flag though. Not sure why each region is so different. Stamps also don't exist in ca and USA. They do exist in Australia though.

fuatakgun · 2024-01-17T18:43:26Z

Austria is following EU style, right? Similar to IN and CN.

cdnninja · 2024-01-17T19:07:41Z

Yes.

Bubo08 · 2024-01-17T21:07:35Z

I head to add the attribute Ccuccs2protocolsupport to the header. The value is taken from the result of the vehicle call. It would be good if somebody could test it for the old cars in EU.

jwillemsen · 2024-01-18T08:06:37Z

I have a 2024 Kona and just tried this PR using a small test script, I do see a lot more data now being returned, including a lot of driving statistics, great work!

Bubo08 · 2024-01-19T07:13:36Z

I have a 2024 Kona and just tried this PR using a small test script, I do see a lot more data now being returned, including a lot of driving statistics, great work!

Thanks! I mapped some additional attributes and documented the still missing ones.

ristoavila · 2024-01-19T21:49:28Z

0001-Try-to-map-more-values.patch
I tried to map some more values. Now it shows 43 entitys for EV9. Setting any of the values is still not working and the lock state is not correct but at least the charging limits can be seen and also estimated charging duration.

cdnninja

Good with this being merged. @fuatakgun let us know when you test on your car.

hyundai_kia_connect_api/KiaUvoApiEU.py

Bubo08 · 2024-01-20T14:20:43Z

I tried to map some more values. Now it shows 43 entitys for EV9.

All are integrated now. Thanks for your help.

ristoavila · 2024-01-20T20:07:59Z

I tried to map some more values. Now it shows 43 entitys for EV9.

All are integrated now. Thanks for your help.

Some fixes for previous mapping. I also mapped is_locked to driver door lock. Would be nice to get sniffing of the open lock and setting of the limits.
0001-Fix-value-states-for-added-attributes.patch

Bubo08 · 2024-01-21T07:16:58Z

I added the proposed changes and also changed the is_locked. All door are checked and only if all four are closed then I set the attribute to True.

ristoavila · 2024-01-21T10:29:23Z

I added the proposed changes and also changed the is_locked. All door are checked and only if all four are closed then I set the attribute to True.

Btw there is Lock status that is inverse its different from open. Property is Cabin.Door.Row1.Driver.Lock its 1 when its open and 0 when its locked.

cdnninja · 2024-01-21T20:16:52Z

Thank you for this! I am going to merge and release this. Another PR can be done for the other work that is on the go. This will help test the current progress out in a wider audience.

jwillemsen · 2024-01-23T12:29:49Z

With the pre release 2.19.0 I do see much more data, but KONA AC Charging Limit and KONA DC Charging Limit but show a slider with 80, but in the app I see 100, also the UI is strange

In the data field I see

TargetSoC:
      Standard: 100
      Quick: 100

jwillemsen · 2024-01-23T12:45:59Z

I don't have FrontLeftWindow and FrontRightWindow in HA, only the door, for the back I do see the door and window status

jwillemsen · 2024-01-23T12:47:27Z

The kona has vehicle to load, in the data field I see the following, looks this is not exported separately to HA

VehicleToLoad:
        DischargeLimitation:
          SoC: 20

jwillemsen · 2024-01-23T13:15:07Z

See #483 for the window status

Bubo08 and others added 2 commits January 15, 2024 22:14

CCS2 changes for newer EU KIA models - only main attributes

829e099

fix: black action

3fff6f7

fuatakgun requested a review from cdnninja January 15, 2024 21:59

fuatakgun reviewed Jan 15, 2024

View reviewed changes

Bubo08 and others added 2 commits January 16, 2024 23:23

naming fix & additional attributes

0fbfcf0

Merge branch 'Hyundai-Kia-Connect:master' into ccs2-changes

dd969a4

Bubo08 changed the title ~~CCS2 changes for newer EU KIA models - only main attributes~~ fix: CCS2 changes for newer EU KIA models - only main attributes Jan 17, 2024

Bubo08 mentioned this pull request Jan 17, 2024

EV9 is not showing as an EV and is not recognized Hyundai-Kia-Connect/kia_uvo#766

Closed

correction for low and high voltage battery

3759f72

fixed driving history

57b6d7c

Bubo08 mentioned this pull request Jan 17, 2024

No totalPwrCsp available #440

Closed

jwillemsen mentioned this pull request Jan 18, 2024

Missing entities : EV Battery level #477

Closed

Bubo08 and others added 2 commits January 19, 2024 08:06

Additional fields mapping

21551f1

fix: black action

26d397a

cdnninja approved these changes Jan 19, 2024

View reviewed changes

hyundai_kia_connect_api/KiaUvoApiEU.py Show resolved Hide resolved

Bubo08 and others added 2 commits January 20, 2024 09:25

Additional attribute mapping

1edb7c7

fix: black action

972d783

Bubo08 and others added 2 commits January 20, 2024 23:19

all locked and other attributes

cad637e

fix: black action

e91dec9

cdnninja changed the title ~~fix: CCS2 changes for newer EU KIA models - only main attributes~~ feat(EU): New KIA models Jan 21, 2024

cdnninja merged commit 0fa2ca4 into Hyundai-Kia-Connect:master Jan 21, 2024
1 check passed

jwillemsen mentioned this pull request Jan 29, 2024

Missing data for ccs2 EU #488

Closed

VolkerK62 mentioned this pull request Apr 3, 2024

Bluelink Vehicle Identification Status Updates not working correctly evcc-io/evcc#13242

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(EU): New KIA models #480

feat(EU): New KIA models #480

Bubo08 commented Jan 15, 2024

Bubo08 commented Jan 15, 2024 •

edited

Loading

fuatakgun left a comment

fuatakgun Jan 15, 2024

Bubo08 Jan 15, 2024

cdnninja Jan 16, 2024

Bubo08 Jan 16, 2024 •

edited

Loading

cdnninja commented Jan 17, 2024

Bubo08 commented Jan 17, 2024

cdnninja commented Jan 17, 2024

Bubo08 commented Jan 17, 2024 •

edited

Loading

cdnninja commented Jan 17, 2024

fuatakgun commented Jan 17, 2024

cdnninja commented Jan 17, 2024

Bubo08 commented Jan 17, 2024

jwillemsen commented Jan 18, 2024

Bubo08 commented Jan 19, 2024

ristoavila commented Jan 19, 2024

cdnninja left a comment

Bubo08 commented Jan 20, 2024

ristoavila commented Jan 20, 2024

Bubo08 commented Jan 21, 2024

ristoavila commented Jan 21, 2024

cdnninja commented Jan 21, 2024

jwillemsen commented Jan 23, 2024 •

edited

Loading

jwillemsen commented Jan 23, 2024

jwillemsen commented Jan 23, 2024

jwillemsen commented Jan 23, 2024

feat(EU): New KIA models #480

feat(EU): New KIA models #480

Conversation

Bubo08 commented Jan 15, 2024

Bubo08 commented Jan 15, 2024 • edited Loading

fuatakgun left a comment

Choose a reason for hiding this comment

fuatakgun Jan 15, 2024

Choose a reason for hiding this comment

Bubo08 Jan 15, 2024

Choose a reason for hiding this comment

cdnninja Jan 16, 2024

Choose a reason for hiding this comment

Bubo08 Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

cdnninja commented Jan 17, 2024

Bubo08 commented Jan 17, 2024

cdnninja commented Jan 17, 2024

Bubo08 commented Jan 17, 2024 • edited Loading

cdnninja commented Jan 17, 2024

fuatakgun commented Jan 17, 2024

cdnninja commented Jan 17, 2024

Bubo08 commented Jan 17, 2024

jwillemsen commented Jan 18, 2024

Bubo08 commented Jan 19, 2024

ristoavila commented Jan 19, 2024

cdnninja left a comment

Choose a reason for hiding this comment

Bubo08 commented Jan 20, 2024

ristoavila commented Jan 20, 2024

Bubo08 commented Jan 21, 2024

ristoavila commented Jan 21, 2024

cdnninja commented Jan 21, 2024

jwillemsen commented Jan 23, 2024 • edited Loading

jwillemsen commented Jan 23, 2024

jwillemsen commented Jan 23, 2024

jwillemsen commented Jan 23, 2024

Bubo08 commented Jan 15, 2024 •

edited

Loading

Bubo08 Jan 16, 2024 •

edited

Loading

Bubo08 commented Jan 17, 2024 •

edited

Loading

jwillemsen commented Jan 23, 2024 •

edited

Loading