Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EU): New models, convert location_last_updated_at to datetime #484

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(EU): New models, convert location_last_updated_at to datetime #484

merged 1 commit into from
Jan 24, 2024

Conversation

ZuinigeRijder
Copy link
Collaborator

@cdnninja hyundai_kia_connect_monitor uses Property Vehicle.location_last_updated_at. A German Kona model 2024 user tried out the support of the new EU models (v3.13.0).

Property Vehicle.location_last_updated_at was not given back a datetime for the EU new models (e.g. Kia EV9, Hyundai Kona 2024 model) but a dictionary. Converted the dictionary to a datetime, like this is done for the other EU models.

Vehicle._location_last_set_time is now also converted to a datetime for the EU new models.

Other improvements:

  • all the supported languages list are two-letters, so no distinguishing of e.g. en-gb or en-us, so just use the first two letters to avoid errors
  • fixed style warning: comparison == False

@ZuinigeRijder ZuinigeRijder changed the title Fix(EU): New models fix, convert location_last_updated_at to datetime EU: New models fix, convert location_last_updated_at to datetime Jan 24, 2024
@ZuinigeRijder ZuinigeRijder changed the title EU: New models fix, convert location_last_updated_at to datetime fix: (EU) New models fix, convert location_last_updated_at to datetime Jan 24, 2024
@cdnninja cdnninja changed the title fix: (EU) New models fix, convert location_last_updated_at to datetime fix(EU): New models, convert location_last_updated_at to datetime Jan 24, 2024
@cdnninja
Copy link
Collaborator

Thanks for this! I think new models are getting much closer.

@cdnninja cdnninja merged commit 13eb4b4 into Hyundai-Kia-Connect:master Jan 24, 2024
15 of 17 checks passed
@ZuinigeRijder ZuinigeRijder deleted the FIX_EU_NEW_MODELS_LOCATION_LAST_UPDATED_AT branch January 24, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants