fix(EU): fill Vehicle.ev_driving_range with Vehicle.total_driving_range for cc2 for pure EV to have similar behaviour for non-cc2 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuinigeRijder
changed the title
ZuinigeRijder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Kona Model 2024 user complained about the non-filled Vehicle.ev_total_driving_range. In the debug log I do not see this information for this cc2 model. When it is a pure EV, the Vehicle.ev_total_driving_range should be identical to the Vehicle.total_driving_range, as is with non-cc2 EU API.
So for pure EV, this can be fixed for cc2 models (identical behaviour for cc2 and non-cc2 users of the API), to fill Vehicle.ev_total_driving_range with Vehicle.ev_total_driving_range. For non pure EV's (e.g. PHEV) it should be investigated further how to get the Vehicle.ev_total_driving_range (TODO kept).