Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KiaUVOApiCA check_action_status #577

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

rjantoine
Copy link
Contributor

Adds synchronicity (run until complete) and returns OrderStatus instead of simply returning True.

@rjantoine
Copy link
Contributor Author

I have tested this and it works as expected.

vm.check_action_status(vehicle_id, action_id, False) only runs once and returns either OrderStatus.FAILED, SUCCESS or PENDING.

vm.check_action_status(vehicle_id, action_id, True, timeout) runs every 10 seconds until return status is OrderStatus.FAILED, SUCCESS or timeout is reached and returns TIMEOUT.

@cdnninja
Copy link
Collaborator

Awesome! I haven't looked at other regions. I assume eu appears to have same behaviour?

@rjantoine
Copy link
Contributor Author

Although it’s implemented differently, yes, this code behaves the same way as the EU check_action_status and the same way as specified in coordinator.

@cdnninja
Copy link
Collaborator

Thanks for confirming!

@cdnninja cdnninja merged commit be9b0d7 into Hyundai-Kia-Connect:master Jun 19, 2024
5 checks passed
@rjantoine
Copy link
Contributor Author

The only region that doesn’t behave this way is the US. BluelinkApiUS doesn’t even have a check_action_status.

KiaUvoApiUSA has check_action_status but it simply returns True. It does not have a synchronous option implemented and does not return the OrderStatus constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants