Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for full VAST 4.2 support #7

Open
goosemanjack opened this issue Jul 31, 2019 · 3 comments
Open

Update for full VAST 4.2 support #7

goosemanjack opened this issue Jul 31, 2019 · 3 comments

Comments

@goosemanjack
Copy link
Contributor

This tool currently indicates 4.x support is incomplete. Please LMK if any effort is underway to update as VAST 3.x spec is in maintenance not being enhanced anymore.

@timdp
Copy link
Collaborator

timdp commented Aug 2, 2019

Good question! The lack of VAST 4.x support is twofold:

  • We're still updating the underlying iab-vast-model package for VAST 4.1 (and 4.2). This will give us a more complete in-memory VAST document.

  • We need to determine which aspects of VAST 4.0 and up need to be taken into account for the tester. Notably, we'll want to extend support for OMID, and introduce support for SIMID. However, there are most likely other things we want to add here, such as additional tracking events.

I deliberately made the error message state that support is "incomplete" rather than missing entirely. That provides us with an incremental adoption path, just like VAST itself.

Did you have any particular features in mind? We can prioritize based on demand as well.

@goosemanjack
Copy link
Contributor Author

There is no specific element. Rather I'm looking to get the various IAB tools in sync. I maintain the VAST XSD and samples. If possible we'd like to have parity across the efforts.

You might consider an XSD to JS class generator. It appears to be what most consumers are doing (into their preferred language). It helps twofold b/c in addition to language-specific tooling, it identifies issues in the xsd which I can then address. Normally I do Java (Jaxb) and C# (xsd.exe) for testing. I haven't played with Javascript generation, but here are a couple of options if you want to explore that path.

https://github.com/spreeuwers/xsd2ts
https://docs.microsoft.com/en-us/previous-versions/dotnet/netframework-1.1/x6c1kb0s(v=vs.71)

@timdp
Copy link
Collaborator

timdp commented Sep 23, 2019

Sorry about the belated response.

I deliberately didn't go with an XSD-to-class generator originally.

The main reason for this is that the VAST spec contains a bit of indirection that I aimed to get rid of. Notably, there are a bunch of superfluous parent elements like <Ad>, <Creative>, and <MediaFiles> that would make the code really verbose. I also never got why there are sequence attributes in a document that's inherently ordered.

These are some of the things that iab-vast-model tries to improve on, by giving you a friendlier API. Of course, conversely, that means keeping it in sync with the latest spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants