Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep As Android integration configure dialog does not show actual current settings #33

Closed
thomasfinstad opened this issue Feb 18, 2022 · 1 comment · Fixed by #34
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@thomasfinstad
Copy link

General information

Home Assistant

Version:
Installation method (according to instructions):
[X] Operating System
[ ] Container
[ ] Supervised
[ ] Core

Integration

Installation method:
[X] HACS
[ ] manual from release
[ ] manual from git
Integration version:
Root topic:

Application settings

topic:
[X] I can see MQTT messages from application at MQTT-server

How it works now?

The integration settings does not show what is really current, but always the default.
The integration / sensor works as expected.

What do you expect?

The integration settings (name/topic/qos) to reflect what is really configured

Steps to reproduce

  1. install as normal
  2. during integration configuration change the topic, I just prefixed the default so my full topic is sensor/SleepAsAndroid/%%%device%%%
  3. save
  4. either watch the logs with debug enabled or use another mqtt client to watch the topic
  5. use the android app to test with the same topic (or another client with your own json payload)
  6. sensor should recieve the test event and work as normal
  7. when looking at the integration configuration again the default values will show instead of the real one with a different topic
  8. you can now change the topic as you wish (just restart HA after changing to make them take effect)
  9. the topic you enter will work, but not show up in the settings dialog

Debug log

2022-02-18 16:34:32 WARNING (MainThread) [custom_components.sleep_as_android.sensor] Got Unknown event, but it is not in TRIGGERS list: will not fire this event for trigger!

Additional information

The fact that the config box does not mention the need for a restart, and the box not fetching the active real settings it looks to be completely broken even though it works.

@IATkachenko IATkachenko self-assigned this Feb 18, 2022
@IATkachenko IATkachenko added the bug Something isn't working label Feb 18, 2022
@IATkachenko
Copy link
Owner

Thank you for report.
Will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants