Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Version module to README #42

Closed
pedro042 opened this issue May 10, 2022 · 2 comments
Closed

Add note about Version module to README #42

pedro042 opened this issue May 10, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@pedro042
Copy link

Hi Igor,

I spent hours (actually days) to get this component working. I had getting error like "Unknown module pyhaversion" or so (I don've the logs). And the solution was very simple - enable Version module https://www.home-assistant.io/integrations/version
Please add note to README file about this (HA-SleepAsAndroid requires Version module enabled).
I installed it directly, just copied it to custom_components directory without HACS

Great work, thank you very much for this component!

@IATkachenko
Copy link
Owner

@pedro042, hello.

Sorry for this.

I'm using

default: 

set in configuration.yaml, and it seems that version is in this set.

I'll update readme and add dependency. Other option is completely remove version check and bump minimal Home Assistant version for the integration: version is used to keep compatibility with old versions of HomeAssistant.

Looks like first simplest solution will be add info to README, and then I'll review code.

@IATkachenko IATkachenko added documentation Improvements or additions to documentation enhancement New feature or request labels May 11, 2022
@IATkachenko
Copy link
Owner

IATkachenko commented May 11, 2022

Actually we don't need this integration. There is only pyhaversion python module is needed from its requirements.
Fixed in v1.9.1 by adding it to own requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants