Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Navbar issue solved #559

Merged
merged 2 commits into from
Dec 20, 2022
Merged

[Bug] Navbar issue solved #559

merged 2 commits into from
Dec 20, 2022

Conversation

AbhiPatel10
Copy link
Contributor

@AbhiPatel10 AbhiPatel10 commented Dec 17, 2022

Two Navbar shows in Some pages so remove in all pages and only one navbar is app.jsx file

Fixes Issue

Closes :- [BUGS] Shows two navbar in Shop Page #556

Closes :- [BUGS] Navbar is Not Responsive #555

My PR closes #issue_number_here

Changes proposed

What were you told to do ?

What did you do ?

All Pages Where Navbar Component is there


Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Screenshots

image

Two Navbar shows in Some pages so remove in all pages and only one navbar is app.jsx file
@vercel
Copy link

vercel bot commented Dec 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
milan ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 7:21PM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello contributor, thank you for opening a Pull Request 🎉.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out Tamal Das on Twitter.
Star ⭐ this repo to show us support.

Happy, Open Source!

@vercel vercel bot temporarily deployed to Preview December 17, 2022 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2022 19:21 Inactive
@AbhiPatel10 AbhiPatel10 changed the title [Bug] Two Navbar issue solved [Bug] Navbar issue solved Dec 17, 2022
@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🟧 priority: high area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Dec 19, 2022
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the hard work ✅
Keep contributing to Opensource !

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. Completed ✅ and removed status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Dec 20, 2022
@tamalCodes tamalCodes merged commit b2a155b into ngoworldcommunity:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants