Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress resize for autoscaled workerpools #4533

Merged
merged 3 commits into from
May 10, 2023

Conversation

z0za
Copy link
Contributor

@z0za z0za commented Apr 20, 2023

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

% make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVpcClusterWorkerPoolEnvvar'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVpcClusterWorkerPoolEnvvar -timeout 700m
...
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolEnvvar (2231.01s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      2232.690s



% make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerWorkerPoolBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerWorkerPoolBasic -timeout 700m
...
=== RUN   TestAccIBMContainerWorkerPoolBasic
--- PASS: TestAccIBMContainerWorkerPoolBasic (1324.47s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1325.922s


% make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar -timeout 700m
...
=== RUN   TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar
--- PASS: TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar (2128.07s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      2129.463s



% make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerWorkerPoolDataSource_basic'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerWorkerPoolDataSource_basic -timeout 700m
...
=== RUN   TestAccIBMContainerWorkerPoolDataSource_basic
--- PASS: TestAccIBMContainerWorkerPoolDataSource_basic (1682.22s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1683.884s
...

@z0za z0za force-pushed the autoscale_enabled branch 2 times, most recently from 9a5347e to ea49b20 Compare May 2, 2023 07:46
@z0za z0za marked this pull request as ready for review May 2, 2023 09:11
@hkantare hkantare merged commit 221ca84 into IBM-Cloud:master May 10, 2023
2 checks passed
@z0za z0za deleted the autoscale_enabled branch May 10, 2023 10:22
omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this pull request Jul 20, 2023
* suppress resize for autoscaled workerpools

* add autoscale_enabled to datasource

* autoscale_enabled is added to docs

---------

Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants