Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description property of cis_filter and cis_firewall_rule bugged #5378

Open
pauljegouic opened this issue May 21, 2024 · 5 comments
Open

description property of cis_filter and cis_firewall_rule bugged #5378

pauljegouic opened this issue May 21, 2024 · 5 comments

Comments

@pauljegouic
Copy link

pauljegouic commented May 21, 2024

image

We got the following error when the value of description is changed on both resource (even if cis_filter not displayed here)

Expected behaviour: I can set whatever string I want or don't fill this field

@pauljegouic
Copy link
Author

Tested with 1.65.1 and 1.66.0-beta0

@pauljegouic
Copy link
Author

@hkantare

@hkantare
Copy link
Collaborator

@arpit-srivastava-ibm why do we have validation on description field ?

@arpit-srivastava-ibm
Copy link
Contributor

@arjunchauhanibm Please have a look and see if any changes are required here.

@arjunchauhanibm
Copy link
Contributor

@pauljegouic
This feature was released 3 years back and we were unaware of this bug. There was validation present on the description field.

I have removed the validation and created a PR for the same.
#5382

@hkantare can you please review the PR. After making the changes i was able to create firewall rules with custom description. I have added the ss in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants