Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silence compiler warnings #74

Merged
merged 1 commit into from Aug 5, 2022
Merged

silence compiler warnings #74

merged 1 commit into from Aug 5, 2022

Conversation

mman
Copy link
Contributor

@mman mman commented Jan 19, 2022

Silence Compiler Warnings on Xcode 13

Motivation and Context

Clean Build(™)

How Has This Been Tested?

Xcode 13 with swift 5.5 rebuild

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mbarnach
mbarnach approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@mbarnach mbarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sbeitzel
Copy link

sbeitzel commented Aug 3, 2022

Is there a good reason this hasn't been merged? The change seems innocuous and it will clean up build warnings for everyone.

@dannys42 dannys42 merged commit cec97c2 into Kitura:master Aug 5, 2022
@dannys42
Copy link
Contributor

dannys42 commented Aug 5, 2022

Merged and tagged as 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarnach mbarnach mbarnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mman @CLAassistant @sbeitzel @dannys42 @mbarnach