Fix for Ubuntu 14.04 and OpenSSL 1.0.1 #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.swiftlint.yml
Outdated
| - trailing_newline | ||
| - force_cast | ||
| - function_body_length | ||
| - variable_name | ||
| - indentifier_name |
There was a problem hiding this comment.
Surely identifier_name?
| @@ -467,7 +499,12 @@ class CryptorRSATests: XCTestCase { | |||
| // JWT also does base64url encoding, so make the proper replacements so its proper base64 encoding | |||
| sig = sig.replacingOccurrences(of: "-", with: "+") | |||
| sig = sig.replacingOccurrences(of: "_", with: "/") | |||
| let sigData = Data(base64Encoded: sig)! | |||
|
|
|||
| guard let sigData: Data = Data(base64Encoded: sig) else { | |||
There was a problem hiding this comment.
You should be able to let the compiler infer the type I think.
| @@ -445,11 +476,12 @@ class CryptorRSATests: XCTestCase { | |||
| -----END PUBLIC KEY----- | |||
| """ | |||
|
|
|||
| let tokenPublicKey = try? CryptorRSA.createPublicKey(withPEM: certificatePEM) | |||
| let tokenPublicKey = try CryptorRSA.createPublicKey(withPEM: certificatePEM) | |||
There was a problem hiding this comment.
Better to guard let this, XCTFail(); return in the else, and remove the XCTAssertNotNil() below.
|
@KyeMaloy97: Are you still working on this? The CI checks are failing. Thanks. |
|
@billabt Yea I am still working on it, I am working on removing force unwraps in the Test suite to get the Swift Linter to pass |
|
Cool, I’ll take a look either later today or first thing in the morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where systems using an older version of OpenSSL are not able to build, due to a type mismatch. The PR links to a branch I have made of the OpenSSL module map which now has a wrapper around the method in question (EVP_DigestVerifyFinal) to stop Swift complaining due to a type mismatch.
When the OpenSSL branch is merged into master, I will update this PR to point to the release that contains the fix, rather than the branch. Opening this now so Travis can do some testing.