Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Swift 4.0.2 #70

Merged
merged 1 commit into from Dec 15, 2017
Merged

Migrate to Swift 4.0.2 #70

merged 1 commit into from Dec 15, 2017

Conversation

DunnCoding
Copy link
Contributor

Removes backwards compatibility, full migration to Swift 4.0.2

@tunniclm
Copy link
Collaborator

@sandmman As this will break compatibility with Swift 3, I assume we want to bump the major (or at least the minor) when we tag this?

@codecov-io
Copy link

Codecov Report

Merging #70 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage    49.6%   49.47%   -0.13%     
==========================================
  Files          12       12              
  Lines        1633     1633              
  Branches       71       71              
==========================================
- Hits          810      808       -2     
  Misses        799      799              
- Partials       24       26       +2
Flag Coverage Δ
#CouchDB 49.47% <100%> (-0.13%) ⬇️
#CouchDBSample 49.47% <100%> (-0.13%) ⬇️
Impacted Files Coverage Δ
Sources/CouchDB/Database.swift 48.45% <100%> (-0.29%) ⬇️
Sources/CouchDB/ConnectionProperties.swift 39.28% <0%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdc610...0a65c61. Read the comment docs.

@sandmman
Copy link

sandmman commented Dec 15, 2017

@tunniclm We've been trying to stick with updating the major for breaking changes and minors for new api features. Since we lose Swift 3 support as you mentioned, this will go to 2.0.0.

@sandmman sandmman assigned sandmman and unassigned sandmman Dec 15, 2017
Copy link

@sandmman sandmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sandmman sandmman merged commit 4a4ee30 into master Dec 15, 2017
@sandmman sandmman deleted the issue-478 branch December 15, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants