Add type safe render method #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2018 15:14
ianpartridge
requested changes
May 14, 2018
Package.swift
Outdated
| dependencies: [ | ||
| .Package(url: "https://github.com/IBM-Swift/Kitura-TemplateEngine.git", majorVersion: 1, minor: 7), | ||
| .Package(url: "https://github.com/kylef/Stencil.git", majorVersion: 0, minor: 10) | ||
| .package(url: "https://github.com/IBM-Swift/Kitura-TemplateEngine.git", .branch("master")), |
There was a problem hiding this comment.
Note: need updating once we have a tag.
| throw StencilTemplateEngineError.unableToCastJSONToDict | ||
| } | ||
|
|
||
| json = dict |
There was a problem hiding this comment.
Why not guard let json = try... above, then you wouldn't need this line?
| @@ -50,6 +64,39 @@ public class StencilTemplateEngine: TemplateEngine { | |||
| let environment = Environment(loader: loader, extensions: [`extension`]) | |||
| var context = context | |||
| context["loader"] = loader | |||
| return try environment.renderTemplate(name: templateName, context: context) | |||
| do { | |||
| let result = try environment.renderTemplate(name: templateName, context: context) | |||
There was a problem hiding this comment.
Can't this be return try environment.render... like it was before?
ianpartridge
requested changes
May 21, 2018
| // Thrown when unable to encode the Encodable value provided to data. | ||
| case unableToEncodeValue(value: Encodable) | ||
|
|
||
| // Thrown when GRMustache fails to render the context with the given template. |
ianpartridge
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an implementation for the new type safe rendering method.