Faster way to calculate utf8Length #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies the same performance fix for utf8 length calculation applied in Kitura/Kitura#1369 to Kitura-net, resolves a performance regression when building with Swift 5.0 snapshots.
Motivation and Context
See Kitura/Kitura#1372
How Has This Been Tested?
The Kitura-net tests pass.
Performance evaluation of a Kitura 'hello-world' app show significant improvement for Swift 5 (and a small improvement for Swift 4.2.1), eliminating the regression seen with Swift 5 builds:
Checklist: