Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 4.1 #1230

Merged
merged 3 commits into from Mar 6, 2018
Merged

Support Swift 4.1 #1230

merged 3 commits into from Mar 6, 2018

Conversation

djones6
Copy link
Collaborator

@djones6 djones6 commented Mar 5, 2018

Description

Motivation and Context

Demonstrate that Kitura will support the upcoming Swift 4.1 release.

How Has This Been Tested?

Travis with Swift 4.1 added to matrix

Checklist:

  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@djones6
Copy link
Collaborator Author

djones6 commented Mar 5, 2018

Testcase failures that need resolving...

  • TestCodableRouter.swift:696: error: TestCodableRouter.testCodableGetQueryParameters : XCTAssertTrue failed - Expected some bytes, received 0 bytes.
  • TestCodableRouter.swift:743: error: TestCodableRouter.testCodableDeleteQueryParameters : XCTAssertEqual failed: ("badRequest") is not equal to ("OK") - HTTP Status code was badRequest

These fail on Linux and Mac, and only on Swift 4.1.

@djones6
Copy link
Collaborator Author

djones6 commented Mar 5, 2018

Should be resolved by Kitura/KituraContracts#14
I'll restart the CI

@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

Merging #1230 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files          38       38           
  Lines        2234     2234           
=======================================
  Hits         1997     1997           
  Misses        237      237
Flag Coverage Δ
#Kitura 89.39% <100%> (ø) ⬆️
Impacted Files Coverage Δ
Sources/Kitura/staticFileServer/FileServer.swift 92.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ed3a1...ad4de7e. Read the comment docs.

.travis.yml Outdated
- os: linux
dist: trusty
sudo: required
env: SWIFT_SNAPSHOT=swift-4.1-DEVELOPMENT-SNAPSHOT-2018-02-06-a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test against the latest snapshot please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 03-04-a

Copy link
Collaborator

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis update would be best.

Copy link
Collaborator

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djones6 djones6 merged commit a1cdea1 into master Mar 6, 2018
@djones6 djones6 deleted the issue_swift41-2 branch March 6, 2018 09:43
djones6 added a commit that referenced this pull request Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants