New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Swift 4.1 #1230
Support Swift 4.1 #1230
Conversation
Testcase failures that need resolving...
These fail on Linux and Mac, and only on Swift 4.1. |
Should be resolved by Kitura/KituraContracts#14 |
Codecov Report
@@ Coverage Diff @@
## master #1230 +/- ##
=======================================
Coverage 89.39% 89.39%
=======================================
Files 38 38
Lines 2234 2234
=======================================
Hits 1997 1997
Misses 237 237
Continue to review full report at Codecov.
|
.travis.yml
Outdated
- os: linux | ||
dist: trusty | ||
sudo: required | ||
env: SWIFT_SNAPSHOT=swift-4.1-DEVELOPMENT-SNAPSHOT-2018-02-06-a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test against the latest snapshot please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to 03-04-a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis update would be best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Motivation and Context
Demonstrate that Kitura will support the upcoming Swift 4.1 release.
How Has This Been Tested?
Travis with Swift 4.1 added to matrix
Checklist: