Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make StaticFileServer open class #1245

Merged
merged 1 commit into from Apr 17, 2018
Merged

fix: make StaticFileServer open class #1245

merged 1 commit into from Apr 17, 2018

Conversation

Andrew-Lees11
Copy link
Contributor

Description

In this pull request the StaticFileServer and its handle function were changed from being public to being open.

Motivation and Context

This was done to fix issue #937 and allow you to subclass/override the class.

How Has This Been Tested?

Kitura tests have been run and all pass.

Copy link
Collaborator

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Jazzy docs changes, we have a separate process for generating those now via the jazzy-docs GitHub label.

@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #1245 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files          38       38           
  Lines        2280     2280           
=======================================
  Hits         2031     2031           
  Misses        249      249
Flag Coverage Δ
#Kitura 89.07% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...ces/Kitura/staticFileServer/StaticFileServer.swift 94.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc351a...3bd389b. Read the comment docs.

Copy link
Collaborator

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this removes the Jazzy docs altogether 🤣

Sorry, I meant leave them unchanged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants