Log error in StaticFIleServer init if passed a non-directory path #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilnerm
force-pushed
the
sfs_failableinit
branch
2 times, most recently
from
edb4d9a
to
793eda9
Compare
djones6
requested changes
Jan 21, 2019
|
I have updated the change to be non-breaking. |
djones6
requested changes
Jan 21, 2019
kilnerm
changed the title
djones6
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the StaticFileServer to have a failable initializer, updates the initializer to fail if the
pathparameter is not to a directory and adds a test to ensure the initializer fails whenpathis a file.Motivation and Context
Currently the StaticFileServer documentation states the
pathparameter should be a folder but the initializer will accept a file which can lead to files being incorrectly served. This change prevents this scenario.How Has This Been Tested?
I have added a test which will try to create a StaticFileServer using a path to a file, should the StaticFileServer be successfully created then the test will fail. I have also stepped through the debugger to ensure the code functions as expected.
Checklist: