Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to swift 4.2.1, test on 16.04 / 18.04 #29

Merged
merged 3 commits into from Nov 16, 2018
Merged

Update to swift 4.2.1, test on 16.04 / 18.04 #29

merged 3 commits into from Nov 16, 2018

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Nov 12, 2018

Minor updates for testing:

  • Update .swift-version to 4.2.1,
  • Add Ubuntu 16.04 and 18.04 testing (under Docker),
  • Make the .travis.yml more consistent with other IBM-Swift repos (comments, indentation).

@djones6 djones6 mentioned this pull request Nov 15, 2018
Closed
@djones6 djones6 requested a review from kilnerm November 15, 2018 16:30
kilnerm
kilnerm approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@kilnerm kilnerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kilnerm kilnerm merged commit 8dd700b into next Nov 16, 2018
@kilnerm kilnerm deleted the swift421 branch November 16, 2018 08:14
kilnerm pushed a commit that referenced this pull request Dec 18, 2018
@djones6 @kilnerm
Update to swift 4.2.1, test on 16.04 / 18.04 (#29)
6ef7afb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilnerm kilnerm kilnerm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djones6 @kilnerm