Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build against Swift 5 #31

Merged
merged 1 commit into from Dec 12, 2018
Merged

Build against Swift 5 #31

merged 1 commit into from Dec 12, 2018

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Nov 27, 2018 •
edited

Adds testing with a Swift 5 development snapshot. The snapshot is defined in Travis as SWIFT_DEVELOPMENT_SNAPSHOT consistently across the IBM-Swift repos, to enable us to automate updating the version.

@djones6 djones6 changed the title [WIP] Build against Swift 5 Build against Swift 5 Dec 6, 2018
@djones6 djones6 requested a review from kilnerm December 6, 2018 12:23
kilnerm
kilnerm approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@kilnerm kilnerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I raised an issue to look at adding a Swift 4.2 way of declaring the CMySQL library.

@kilnerm kilnerm merged commit 2b29a0d into next Dec 12, 2018
kilnerm pushed a commit that referenced this pull request Dec 18, 2018
@djones6 @kilnerm
Add Swift 5 builds using SWIFT_DEVELOPMENT_SNAPSHOT (#31)
0c7b834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilnerm kilnerm kilnerm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djones6 @kilnerm