Abstract MySQL types #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
reviewed
Oct 5, 2018
| else | ||
| export DEBIAN_FRONTEND="noninteractive" | ||
| if [[ $MYSQL_VER == 5 ]]; then | ||
| mysql --version || { apt-get update && apt-get install -y pkg-config mysql-server libmysqlclient-dev && service mysql start && mysql --version; } |
There was a problem hiding this comment.
Isn't this going to break once Ubuntu starts installing v8 by default? (or do we just fix it if and when that happens)
djones6
suggested changes
Oct 5, 2018
djones6
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts the mysql data-types that changed between v5 and v8.
It also updates to use the pkgConfig functionality to remove the need for specifying explicit paths to headers and link libraries.