Remove the usage of sed commands #50
Conversation
There was a problem hiding this comment.
In general, this is good. I think it needs a whole heap of comments though about exactly what we're doing, why it's necessary etc.
let projNameLowercase = projName.toLowerCase();
// Only contains alphanumeric characters.
let projNameClean = projName.replace(/^[^a-zA-Z]*/, '')
.replace(/[^a-zA-Z0-9]/g, '');
// Does not contain uppercase letters.
let projNameCleanLowercase = projNameClean.toLowerCase()
let oldProjName = "Generator-Swiftserver-Projects";
let oldProjNameLowercase = "generator-swiftserver-projects";
let oldProjNameClean = "GeneratorSwiftserverProjects";
let oldProjNameCleanLowercase = "generatorswiftserverprojects"
is just a big pile of WTF (not your fault I know!)
|
@ddunn2 CI failed because Swift is not installed. Looks like the previous CI run failed too, but it wasn't reported as a failure? Can you figure out why that happened as well? |
|
@ianpartridge Seems this repo was never set up to actually run Swift commands, so on Linux builds we don't have access to Swift for I'll look into the best way of adding this, I tried Package-Builder but it doesn't seem to want to play ball. |
test.sh
Outdated
| @@ -30,7 +30,21 @@ echo "Installation complete" | |||
| rm "$PKG" | |||
|
|
|||
| install_swift() { | |||
| eval "$(curl -sL https://swiftenv.fuller.li/install.sh)" | |||
| swiftFile = ".swift-version" | |||
| if [ -f "$file" ] | |||
There was a problem hiding this comment.
This isn't right, you should be looking for ~/.swiftenv to determine if swiftenv is installed.
kitura-init.js
Outdated
| console.error(rename.stderr.toString()); | ||
| process.exit(rename.status); | ||
| } | ||
| //Construct a regex expression to replace multiple occurances of oldProjName |
| @@ -99,15 +100,23 @@ function cloneProject(url, branch) { | |||
| } | |||
|
|
|||
| function renameProject() { | |||
There was a problem hiding this comment.
How about a comment above this function to the effect of:
Projects created with
kitura initstart by cloning a template project, and renaming elements of that project to match the user's chosen project name (determined by the name of their current directory). We perform this renaming for three variants of the project's name: The original name as given, the same name with special characters stripped (as required by SwiftPM), and the stripped name also lowercased (used for example in the name of Docker containers generated by 'kitura build' and 'kitura run').
The behaviour of the
sedcommands differs slightly on macOS and Linux. As such the CLI currently isn't working on Linux.To resolve this I've removed the usage of
sedcommands and instead I use thereplace-in-filenpm package. I also added a test to ensure we attempt to build the projectkitura initcreates to verify it can build successfully.