Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporary ignore some DNS checks #212

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

smolin-de
Copy link
Contributor

There are several open issues related to DNS. DNS setup needs to be verified. We ignore some DNS check results for now, because of issue 166, 182.

@AmadeusPodvratnik
Copy link
Collaborator

@smolin-de I looked into #182 and it looks to me that using

  • { role: check_dns, when env.bastion.options.dns is defined and env.bastion.options.dns} instead of
  • check_dns
    in 5_setup_bastion playbook will solve the issue of an external dns, correct?
    But looking in Playbook 5 says dig validation of DNS fails, but dig lookup commands are succesful #166 we can fix it differently...
    As far as I understood the issues is, that the output of services_lookup.stdout is different from bastion ip (check in check-dns role: (env.bastion.options.loadbalancer.on_bastion == True) and (env.bastion.networking.ip != services_lookup.stdout)).
    If we would like to have an api dns check we need to introduce the IP of the dns server (in all.yaml).

Copy link
Collaborator

@AmadeusPodvratnik AmadeusPodvratnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change the role call in 5_setup_bastion playbook:
{ role: check_dns, when env.bastion.options.dns is defined and env.bastion.options.dns} instead of
check_dns

@smolin-de smolin-de closed this Oct 12, 2023
@smolin-de smolin-de reopened this Oct 12, 2023
There are several open issues related to DNS. DNS setup needs to be verified.
We ignore some DNS check results for now, because of issue 166, 182.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
Copy link
Collaborator

@AmadeusPodvratnik AmadeusPodvratnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@AmadeusPodvratnik AmadeusPodvratnik merged commit 5d0c254 into IBM:main Oct 12, 2023
1 check passed
@smolin-de smolin-de deleted the temporary_dns_fix branch October 30, 2023 21:19
jacobemery pushed a commit that referenced this pull request Dec 20, 2023
There are several open issues related to DNS. DNS setup needs to be
verified. We ignore some DNS check results for now, because of issue
166, 182.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants