fix: Conform proxy vars #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy variables in all.yaml didn't conform to the "env." standard that all the other variables use. Feedback from users said it was confusing and caused some issues. Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
|
@smolin-de Can you review this? |
|
@smolin-de when merging, could you change this PRs title to "fix: conform proxy vars #79" to match the semantic release naming conventions? |
smolin-de
approved these changes
Jan 26, 2023
AmadeusPodvratnik
pushed a commit
to AmadeusPodvratnik/Ansible-OpenShift-Provisioning
that referenced
this pull request
Feb 13, 2023
Proxy variables in all.yaml didn't conform to the "env." standard that all the other variables use. Feedback from users said it was confusing and caused some issues. Signed-off-by: Jacob Emery <jacob.emery@ibm.com> Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jacobemery
added a commit
that referenced
this pull request
Dec 20, 2023
Proxy variables in all.yaml didn't conform to the "env." standard that all the other variables use. Feedback from users said it was confusing and caused some issues. Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy variables in all.yaml didn't conform to the "env." standard that all the other variables use.
Feedback from users said it was confusing and caused some issues.
Signed-off-by: Jacob Emery jacob.emery@ibm.com