Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set more specific batch bundle action in audit event when possible #1817

Closed
lmsurpre opened this issue Dec 11, 2020 · 2 comments
Closed

Set more specific batch bundle action in audit event when possible #1817

lmsurpre opened this issue Dec 11, 2020 · 2 comments
Assignees
Labels
audit P3 Priority 3 - Nice To Have

Comments

@lmsurpre
Copy link
Member

Is your feature request related to a problem? Please describe.
In #1813, we introduce a change to start logging batch/transaction bundle requests via an audit event with action "E".
However, for bundles which are all reads, all creates, all updates, or all deletes, we should be able to be a little more specific.

Describe the solution you'd like
If the bundle is all reads, set "R".
If the bundle is all creates, set "C".
If the bundles is all updates, set "U".
If the bundle is all deletes, set "D".
Else, set "E".

Describe alternatives you've considered
If we decided to log each individual entry for both batch and transaction bundles (see #1816), then this task becomes a lot less important, because we would already have the info from each individual entry from within the bundle.

Additional context
Currently, we track how many reads, creates, and updates we have for each bundle. But for some reason we don't track how many deletes. That should be added under this work item so that we can set the action to "D" when appropriate.

@prb112 prb112 added the audit label Feb 1, 2021
@lmsurpre
Copy link
Member Author

Could be done together with #1816

@lmsurpre lmsurpre added the P3 Priority 3 - Nice To Have label Feb 22, 2021
prb112 added a commit that referenced this issue May 28, 2021


Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 self-assigned this May 28, 2021
@prb112 prb112 added this to the Sprint 2021-07 milestone May 28, 2021
prb112 added a commit that referenced this issue Jun 3, 2021
Set more specific batch bundle action in audit event when possible #1817
@d0roppe
Copy link
Collaborator

d0roppe commented Jun 4, 2021

Verified the different "action" tags of "R", "C", "U". "D", and "E" are in the audit record. Noting that a PUT no matter the return code (201, or 200) is marked as an Update. Will create a new issue for this in case we want to address that.

@d0roppe d0roppe closed this as completed Jun 4, 2021
tbieste pushed a commit that referenced this issue Jun 9, 2021


Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste pushed a commit that referenced this issue Jun 9, 2021
Set more specific batch bundle action in audit event when possible #1817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit P3 Priority 3 - Nice To Have
Projects
None yet
Development

No branches or pull requests

3 participants