Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patient Export without Type results in a failed export #2012

Closed
prb112 opened this issue Mar 2, 2021 · 2 comments
Closed

Patient Export without Type results in a failed export #2012

prb112 opened this issue Mar 2, 2021 · 2 comments
Assignees
@prb112
Labels
bug Something isn't working bulk-data
Milestone
Sprint 2021-04

Comments

@prb112
Copy link
Contributor

prb112 commented Mar 2, 2021

Describe the bug
Patient Export without Type results in a failed export

To Reproduce
Steps to reproduce the behavior:

  1. Setup BulkData
  2. Execute a Patient Export
    curl -k -u "fhiruser:${PASS}" -H "Content-Type: application/fhir+json" -X GET
    'https://localhost:9443/fhir-server/api/v4/Patient/$export?_outputFormat=application/fhir%2Bndjson'
    -v --header "X-FHIR-TENANT-ID: ${TENANT_ID}"

Results in
{"resourceType":"OperationOutcome","id":"c0-a8-56-16-2cba4727-e321-431b-95da-c09785ea7583","issue":[{"severity":"error","code":"invalid","diagnostics":"Resource Type outside of the Patient Compartment in Export"}]}

This is a subtle issue in the processing of the Parameters object where the _type is not specified, and we stop the processing.

Expected behavior
Pickup the Resources in the compartment only.

Additional context
n/a
@prb112 prb112 added bug Something isn't working bulk-data labels Mar 2, 2021
@prb112 prb112 added this to the Sprint 2021-03 milestone Mar 2, 2021
@prb112 prb112 self-assigned this Mar 2, 2021
@prb112 prb112 linked a pull request Mar 2, 2021 that will close this issue
Improve ImportExport with JavaBatch #1999
Merged
prb112 added a commit that referenced this issue Mar 3, 2021
@prb112
Improve ImportExport with JavaBatch
19c1253 
- Fix Patient Export without Type results in a failed export #2012
	- we now check if it's not set, and add the default resource types from
the compartment
- Add test scripts
- Fix context handling in GroupChunkReader

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 removed a link to a pull request Mar 9, 2021
Improve ImportExport with JavaBatch #1999
Merged
@d0roppe
Copy link
Collaborator

d0roppe commented Mar 11, 2021

more testing needed see issue #2059

@prb112 prb112 modified the milestones: Sprint 2021-03, Sprint 2021-04 Mar 15, 2021
@d0roppe
Copy link
Collaborator

d0roppe commented Mar 19, 2021

Verified this is now working as expected. and no error as described in the issue

@d0roppe d0roppe closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
bug Something isn't working bulk-data
Projects
None yet
Milestone
Sprint 2021-04
Development

No branches or pull requests
2 participants
@prb112 @d0roppe