Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all OperationDefinition resources are pulled from FHIRRegistry for specification-defined operations (e.g. $everything) #2057

Closed
JohnTimm opened this issue Mar 11, 2021 · 2 comments
Closed

Ensure all OperationDefinition resources are pulled from FHIRRegistry for specification-defined operations (e.g. $everything) #2057

JohnTimm opened this issue Mar 11, 2021 · 2 comments
Assignees
@lmsurpre
Labels
enhancement New feature or request
Milestone
Sprint 2021-05

Comments

@JohnTimm
Copy link
Collaborator

Previously, we would include a copy of the OperationDefinition resource in the implementation of that operation. The FHIRRegistry provides access to all spec artifacts and, as a best practice, should be used to access definitions for specification-defined operations.
@JohnTimm JohnTimm added the enhancement New feature or request label Mar 11, 2021
@lmsurpre
Copy link
Member

lmsurpre commented Apr 13, 2021 •
edited
Loading

Maybe we can tackle this one together with #2241

lmsurpre added a commit that referenced this issue Apr 13, 2021
@lmsurpre
issues #2241 and #2057 - load operation from registry and skip warning
d8104dc 
With this pull request, the spec-defined OperationDefinitions are now
pulled from the registry instead of having them copied to each
individual module.

Additionally, because so many of these spec-defined OperationDefinitions
violate opd-0 (`name.matches('[A-Z]([A-Za-z0-9_]){0,254}')`), I toned
down the logging so that only validation errors are logged by default
(and not validation warnings).

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 13, 2021
@lmsurpre
issues #2241 and #2057 - load operation from registry and skip warning
c8728fa 
With this pull request, the spec-defined OperationDefinitions are now
pulled from the registry instead of having them copied to each
individual module.

Additionally, because so many of these spec-defined OperationDefinitions
violate opd-0 (`name.matches('[A-Z]([A-Za-z0-9_]){0,254}')`), I toned
down the logging so that only validation errors are logged by default
(and not validation warnings).

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 13, 2021
@lmsurpre
issues #2241 and #2057 - load operation from registry and skip warning
2ed6cea 
With this pull request, the spec-defined OperationDefinitions are now
pulled from the registry instead of having them copied to each
individual module.

Additionally, because so many of these spec-defined OperationDefinitions
violate opd-0 (`name.matches('[A-Z]([A-Za-z0-9_]){0,254}')`), I toned
down the logging so that only validation errors are logged by default
(and not validation warnings).

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre self-assigned this Apr 13, 2021
@lmsurpre lmsurpre added this to the Sprint 2021-05 milestone Apr 13, 2021
@prb112
Copy link
Contributor

prb112 commented Apr 13, 2021

I tried with the $everything operation and $convert and $document and $validate.
All looks good

@prb112 prb112 closed this as completed Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 2021-05
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @JohnTimm